HDPVR Commercial Detection

[ericscottf]

I was just about to say... That would have made my video really really long..

Anyway, i'll test tonight and post my results. Thanks for the help!

[Taddeusz]

Originally Posted by Fuzzy

Yeah (well no) It's in milliseconds... sorry.. just woke up...

Yea, that's what I meant. ;-P

[Taddeusz]

Got a reply back from George saying the reason they implemented the time scaling was because they were getting too many support questions asking why their records were a couple seconds too short. Reasonably technical people would understand that it takes a couple seconds for the tuner to tune but I can see how it would confuse someone who wouldn't understand this concept.

[ericscottf]

That makes sense to me, but it would also make sense to keep an invisible timescale from which to do all the sensitive math.

anyway, fuzzy's fix seems to work for me. Comskip still needs more playing, but for some 50% of my shows, it is perfect, showing me one second of commercial on each side, just what i'd like.

previously, it would cut off the show for a few seconds and show me a few seconds of commercial by the time the show was half over.

thanks fuzzy!

[Taddeusz]

As for myself I have to either wait for SageTV 7 to come out or for someone to implement this workaround in SageMC. Can't stand the default STV.

[ericscottf]

You could write a program to modify the edl files if you were so inclined.
Fuzzy's fix does this internally, but there's no reason that modifying the edl before it hits comskip wouldn't work.

[Taddeusz]

True, if I got the calculations he uses I could create a batch file which creates a new modified edl file. My only concern would be making sure that ShowAnalyzer was finished before creating the modified edl.

[ericscottf]

You can do math in a batch file? and read in lines from another file?

This would probably be best done in C. Yes, you'll need to know when SA is done. I imagine that SJQ can do such things?

[Taddeusz]

Originally Posted by ericscottf

You can do math in a batch file? and read in lines from another file?

This would probably be best done in C. Yes, you'll need to know when SA is done. I imagine that SJQ can do such things?

Sort of, there is a command-line program which serves the purpose. However, thinking about it, I could probably manage it in C. I just haven't exercised those skills in quite a while.

It's a little more complicated with SAV1. It has its own queue. So when you execute ShowAnalyzer.exe it simply puts the item in the queue rather than running it immediately as with the old version. As a result it appears to SJQ that it has already completed.

[ericscottf]

Perhaps SA has a feature to dump a file indicating that processing is complete?
Alternately, monitor the SA thread for activity and operate on the file when it is 0%?
or you could constantly try to write to the edl file - which should fail if SA keeps the file handle open - and operate on it when the file is free... Not good if SA only opens the file when it finds a commercial and closes it while processing...
Does SA have a log feature that dumps a file you can watch for a key word like "100%" or "finished" or some such?

[Taddeusz]

Originally Posted by ericscottf

Perhaps SA has a feature to dump a file indicating that processing is complete?
Alternately, monitor the SA thread for activity and operate on the file when it is 0%?
or you could constantly try to write to the edl file - which should fail if SA keeps the file handle open - and operate on it when the file is free... Not good if SA only opens the file when it finds a commercial and closes it while processing...
Does SA have a log feature that dumps a file you can watch for a key word like "100%" or "finished" or some such?

Yes, the log appears to be space delimited and the last line reads something like:

[A59] 2010/05/11 15:29:22.203125  Exiting normally with code 0

The first three values change but the message at the end is always the same.

Can't remember how I'd parse that in C though.

[ericscottf]

There are far more efficient ways to do find-a-string-in-a-string, but here's one.

some of the more efficient ones will search for the last letter of the wanted string, starting at a point into the target string that is the length of the wanted string, and move around by lengths of the target string to be much much more efficient than this, but you're not doing db searches for google here, so this will suffice.

unsigned int findstr(char targetstring[], char wantedstring[], unsigned int start){
unsigned int loc;
unsigned int i,j,k;
unsigned char len;
unsigned char inc;
inc=0;
len = strlen(wantedstring);

if (start==0 || start > strlen(targetstring))
	start=1;

for (i=(start-1);1;i++){

	for (j=0;j<len;j++){
		if (targetstring[i+j]==wantedstring[j]){
			inc++;
			if (inc==len)
				return(i+1);
		}
		else{
			inc=0;
			break;
		}
}
}

return(0);
}

Edit: Watch out for artificial string length issues with the typedefs in the code above. I pulled it from an embedded project of mine where no string would have been longer than 100 chars and memory was very precious.
Oh, and hey, wtf, tabs don't go through on this forum?!

[razrsharpe]

Originally Posted by ericscottf

Oh, and hey, wtf, tabs don't go through on this forum?!

put it in [code] brackets and they should come through just fine...

[Fuzzy]

The problem with 'correcting' the edl itself, is that it is essentially making the EDL incorrect. Then, when sage does release a fix, they'll all be trash, and have to be redone.

Also, just to point something out, I'm almost certain there will be no SageMC after Sage7 is released. The UI itself will probably be the biggest change in Sage7, and with it, SageMC will probably be broken, with no-one really interested in fixing it (as they're all onto newer projects).

[Taddeusz]

I would try and copy your code into SageMC but browsing through I didn't see anything similar to the comskip code in there and besides my programming skills are rusty at best. I'd be better at creating my own program from scratch rather than trying to figure out someone else's.

[ericscottf]

Obviously we'd be breaking the EDL, but once sage7 was installed, the user would recognize that something is wrong, then remember this whole thing, then disable the edl-fixer.

what's more, the impression that i got was that the time scaling would be an option, on by default in 7, so installing 7 wouldn't even break things unless i misread things...

Instead of having SA constantly running, one could launch it with some software that monitored the thread and ran the fixer when the thread was terminated...

[Taddeusz]

Originally Posted by ericscottf

Obviously we'd be breaking the EDL, but once sage7 was installed, the user would recognize that something is wrong, then remember this whole thing, then disable the edl-fixer.

what's more, the impression that i got was that the time scaling would be an option, on by default in 7, so installing 7 wouldn't even break things unless i misread things...

Instead of having SA constantly running, one could launch it with some software that monitored the thread and ran the fixer when the thread was terminated...

The old SA could work that way. Unfortunately SAV1 doesn't. It has a service that runs all the time. When you execute ShowAnalyzer.exe all it does is place the item in the queue. Then the service will prioritize them and spawn showanalyzerengine programs for each item in the active queue.

[Fuzzy]

Originally Posted by Taddeusz

The old SA could work that way. Unfortunately SAV1 doesn't. It has a service that runs all the time. When you execute ShowAnalyzer.exe all it does is place the item in the queue. Then the service will prioritize them and spawn showanalyzerengine programs for each item in the active queue.

You can use SJQ to launch SAEngine instead, eliminating the SA queue altogether. Then add your extra tasks after SAEngine is done in the SJQ client setup.

[ericscottf]

Yup, what Fuzzy said, or you're going to have to monitor the directory for log files and launch when you see an error code 0.

also remember to somehow mark files that have been post-processed, or you'll shrink your edl file over and over and over and over...

[bialio]

SageMC will work in Sage V7. But don't expect any new features