Sensible plugin change request?

[tmiranda]

Before I submit a change request to Sage I would like a little sanity check please.

Looking at the plugin documentation for the sageEvent "FavoriteModified" I noticed the only parameter passed is the modified Favorite. I think it would be more sensible if the original Favorite was also passed so I do not have to do a lot of work to figure out a "best guess" on which Favorite was modified. In the Studio docs I see that the first parameter to UpdateFavorite() is the original Favorite so I think my request is reasonable.

Feedback from the gurus appreciated.

Tom

[GKusnick]

I'm not sure I understand the question. The Favorite passed in to the event listener is presumably the same Favorite object as the one passed in to UpdateFavorite; what else would it be? But since the name of the event is FavoriteModified (past tense), then presumbly the event fires after the modification takes place, so calling FavoriteAPI methods on that object from within the listener will get you the new, modified values. Nevertheless GetFavoriteID should tell you which Favorite it is, since the ID is not mutable via UpdateFavorite.

If what you're asking for is a way to retrieve the old, unmodified values from inside the event listener, that's probably not going to be practical since those old values have been overwritten already. So maybe what you really want is a FavoriteAboutToBeModified event in which you can squirrel away any old values you need for whatever your post-modification listener does with them.

But again, you shouldn't need the old values just to recognize which Favorite it is. The FavoriteID is your unique, invariant handle on a Favorite's identity, and that's what you should be using as the retrieval key for any Favorite-related data you maintain outside the DB.

Or you could use Get/SetFavoriteProperty to store your custom Favorite data in the DB, where it will remain intact across calls to UpdateFavorite.

[tmiranda]

Originally Posted by GKusnick

Nevertheless GetFavoriteID should tell you which Favorite it is, since the ID is not mutable via UpdateFavorite.

Greg,

This was the piece of info I was missing. I want to be able to identify the old Favorite (before it was modified) and did not realize the ID was not changeable. Armed with the ID I can do what I need to do.

Thanks,

Tom

[Fuzzy]

Yeah, they aren't making a new favorite object every time it is changed, they are just changing the modified values in the existing object. The FavoriteModified event is so you can update something else that might depend on the favorites.