SageTVPlugins.xml no longer downloads

[jusjoken]

While working on a few related plugin issues I noted that the HTTP download of the V7 plugin repo seems to now fail on clean installs. I have tested on a new Windows install as well as on the java 8 docker. I assume this is due to the source for those files "http://download.sagetv.com" no longer is supporting http requests.

I am not certain that this is an issue as with the work @JREkiwi did to bring all locatable plugins into the V9 repo and that the V9 repo takes precedence over the V7 repo, then this may be a good thing.

We likely need to do something so that the system does not continually attempt to download the V7 repo but I thought I would at least post this here for awareness and if anyone wants to look into resolving it or suggesting alternatives they could post here.

Downloading new SageTVPlugins.xml file from http://download.sagetv.com/SageTVPlugins.xml

ERROR with file download of:java.io.IOException: Server returned HTTP response code: 403 for URL: http://download.sagetv.com/SageTVPlugins.xml

HTTP Range requests are NOT supported by this server. errcode=403

ERROR failed downloading http://download.sagetv.com/SageTVPlugins.xml file.

k

[Malfunction]

Originally Posted by jusjoken

While working on a few related plugin issues I noted that the HTTP download of the V7 plugin repo seems to now fail on clean installs. I have tested on a new Windows install as well as on the java 8 docker. I assume this is due to the source for those files "http://download.sagetv.com" no longer is supporting http requests.

I am not certain that this is an issue as with the work @JREkiwi did to bring all locatable plugins into the V9 repo and that the V9 repo takes precedence over the V7 repo, then this may be a good thing.

We likely need to do something so that the system does not continually attempt to download the V7 repo but I thought I would at least post this here for awareness and if anyone wants to look into resolving it or suggesting alternatives they could post here.

Downloading new SageTVPlugins.xml file from http://download.sagetv.com/SageTVPlugins.xml

ERROR with file download of:java.io.IOException: Server returned HTTP response code: 403 for URL: http://download.sagetv.com/SageTVPlugins.xml

HTTP Range requests are NOT supported by this server. errcode=403

ERROR failed downloading http://download.sagetv.com/SageTVPlugins.xml file.

k

I've been getting this noise as well. It will check the file and if the checksum is the same *guessing*, not download it. Kind of ugly log entries, but doesn't amount to any problem.

[jusjoken]

Originally Posted by Malfunction

I've been getting this noise as well. It will check the file and if the checksum is the same *guessing*, not download it. Kind of ugly log entries, but doesn't amount to any problem.

On an existing system the checksum may match or likely fail as that call is also through HTTP. As that v7 file is never updated then it will only be niise in the log.

On a clean install the v7 file will never exist. Again, this may not be an issue but only time will tell.

k

[Malfunction]

Originally Posted by jusjoken

On an existing system the checksum may match or likely fail as that call is also through HTTP. As that v7 file is never updated then it will only be niise in the log.

On a clean install the v7 file will never exist. Again, this may not be an issue but only time will tell.

k

Would be nice to eliminate it. I wonder if removing that file would just result in a new download?

[jusjoken]

Originally Posted by Malfunction

Would be nice to eliminate it. I wonder if removing that file would just result in a new download?

On a fresh install it never downloads. I have not tried it yet but deleting it on an existing install should get rid of it and the HTTP downloads from that server fail so without Google overriding that server or recoding sage to use https for that file it likely will never download.

k

[JREkiwi]

That server does support download via HTTPS, but the certificate is not valid, so download fails.

The V9 repository doesn't take precedence over the V7. If the version numbers are the same then the V7 repository is used.

There is probably no need for the V7 repository now as it cannot be updated and all the available plugins are in the V9 repository.

John

[jusjoken]

Originally Posted by JREkiwi

That server does support download via HTTPS, but the certificate is not valid, so download fails.

The V9 repository doesn't take precedence over the V7. If the version numbers are the same then the V7 repository is used.

There is probably no need for the V7 repository now as it cannot be updated and all the available plugins are in the V9 repository.

John

Thanks for the clarification. At some point one of us needs to put in a PR to avoid the v7 download and ignore it for processing plugins. Likely no rush but fixing one plugin at a time may take more time...

k

[jusjoken]

Just placing the thought here as it just popped in my mind...

Does sage use the plugin xml during plugin loading? I assume so as it moves plugins around based on dependencies.

So if we stop using the v7 repo and someone has an old plugin that is NOT in the v9 repo, then the load of that plugin is likely to fail (its install would fail naturally as the source location does not exist and thats why its not in the v7 repo but for older installs we don't want to break those)

We may just need to use the v9 as primary and the v7 f it exists as secondary??

k

[JREkiwi]

Originally Posted by jusjoken

Does sage use the plugin xml during plugin loading? I assume so as it moves plugins around based on dependencies.

So if we stop using the v7 repo and someone has an old plugin that is NOT in the v9 repo, then the load of that plugin is likely to fail (its install would fail naturally as the source location does not exist and thats why its not in the v7 repo but for older installs we don't want to break those)

We may just need to use the v9 as primary and the v7 f it exists as secondary??

I've never really understood/tested this. I was told that removing a plugin from the repository would not break any existing installations, but that has not been my experience. Removing a plugin from the repository stopped it from loading.

Probably needs a real test however.

Another option would be to host the current V7 repository (which hasn't changed for years) on the OpenSageTV github and do a change to have it downloading from there.

John