Plugin: CommercialDetector

[tmiranda]

Originally Posted by Fuzzy

So with the new .JAR you sent me, it is now processing files with spaces in it just fine, and it IS now passing a string array instead of a single string.

Old:  Command sudo -H -u sagetv wine /opt/sagetv/comskip/comskip --playnice --ini=/opt/sagetv/comskip/comskip.ini /var/media/tv/Jerry Springer - S25E80 - Betrayed by My Parrot - 33631125-0.ts
New:  Command [/opt/sagetv/comskip/comskip, --playnice, --ini=/opt/sagetv/comskip/comskip.ini, /var/media/tv/Jerry Springer - S25E80 - Betrayed by My Parrot - 33631125-0.ts]

That means you were not running the latest version from the docker OR you didn't select the "Run native comskip" option.

[stuckless]

Originally Posted by tmiranda

That means you were not running the latest version from the docker OR you didn't select the "Run native comskip" option.

So there's a "run native comskip" option I think that is likely the issue here, since, I noticed that in Fuzzy's logging it was showing "wine", and there is a "wine" stub that I added to the docker image to make running comskip somwhat transparent. I think what I need to do is force the property for run native comskip (if it's not turned on by default).

[tmiranda]

Originally Posted by stuckless

So there's a "run native comskip" option I think that is likely the issue here, since, I noticed that in Fuzzy's logging it was showing "wine", and there is a "wine" stub that I added to the docker image to make running comskip somwhat transparent. I think what I need to do is force the property for run native comskip (if it's not turned on by default).

That's it. Sorry, I thought you had updated the Docker to include that already. Just make sure there is a "comskip64" (native) executable in the same place as comskip.exe.

[peternm22]

I've recently started using this plugin, and for the most part it works great. However, every now and then it doesn't run Comskip on a particular recording. See attached for the log where it fails to run for a recording of Jimmy Kimmel Live. I believe the key part of the log is:

CD: ComskipManager.startFirstInQueue: null MediaFile. Removing job from the queue.

I have Comskip set to run live as the show is recording. I suspect the recording is taking a few seconds to start writing the file (it's a network encoder), and CommercialDetector therefor doesn't see it right away. But that's just a guess.

Any ideas?

[tmiranda]

Yes, that's most likely what is happening.

I'll add this to the "to do" list. I honestly don't know when I'll get to it.....

[waynedunham]

Due to way too many tuners. I have mine set to wait until the recording is done and have a max of 3 instances of Comskip running at a time.

However when I'm recording something very long (i.e. sports), or do want to watch something at least close to live I just tell it to start manually.

Once you have Commercial Detector installed go to Setup/Detailed Setup/Customize. Down in the Extras part of the menu very near the bottom you'll see Comskip Playback Options. Select this and scroll down to Comskip Button Options. I have mine set to Yes/Yes and then you hit the Configure button to point it to where your Comskip is. Just be sure you're pointing it to the donator version if you are using that.

Not ideal, and hopefully they'll put in some kind of timeout value so you can just rely on it to work as you have it set up now. But in the meantime it gives you a way to wait a couple minutes into a recording and start Comskip manually. Plus when Comskip messes up, as it can sometimes do, you can delete the comskip files for a recording and try comskipping it again.

[KarylFStein]

I used to have SJQ check and fire off comskip at 5 and 35 past the hour. That gave a little buffer for things to start up.

[Greg2dot0]

I've been noodling with getting Comskip compiled under Ubuntu 16.04 for a while and finally got it done this past weekend. I've read through this thread and seem to be missing something.

It would appear that the Native Comskip switch never made it to production builds of Commercial Detector. Also, I went through the properties and couldn't find a way to force it in there.

How do I tell Commercial Detector not to use Wine?

Thanks for the help.

[tmiranda]

Originally Posted by Greg2dot0

I've been noodling with getting Comskip compiled under Ubuntu 16.04 for a while and finally got it done this past weekend. I've read through this thread and seem to be missing something.

It would appear that the Native Comskip switch never made it to production builds of Commercial Detector. Also, I went through the properties and couldn't find a way to force it in there.

How do I tell Commercial Detector not to use Wine?

Thanks for the help.

I need to release it. In the mean time I'll post an updated jar here in the next day or so.

[Greg2dot0]

Originally Posted by tmiranda

I need to release it. In the mean time I'll post an updated jar here in the next day or so.

Not to be impatient, but any update on this?

[tmiranda]

Originally Posted by Greg2dot0

Not to be impatient, but any update on this?

Attached. Just replace the existing jar file with this one.

You will need to make a native comskip executable. Name it comskip64 if you are on a 64 bit system or comskip32 if you are on a 32 bit system, and then place it in the same folder as the comskip that comes with the plugin.

[Greg2dot0]

Originally Posted by tmiranda

Attached. Just replace the existing jar file with this one.

You will need to make a native comskip executable. Name it comskip64 if you are on a 64 bit system or comskip32 if you are on a 32 bit system, and then place it in the same folder as the comskip that comes with the plugin.

Awesome , installed and everything actually worked the first time...Thanks a lot!

I actually do a symbolic link to the build directory. This way I can do a git pull and update comskip without having to remember all the steps.

[tmiranda]

Originally Posted by Greg2dot0

Awesome , installed and everything actually worked the first time...Thanks a lot!

I actually do a symbolic link to the build directory. This way I can do a git pull and update comskip without having to remember all the steps.

You're welcome. I really need to release it

[BobPhoenix]

Thoughts on possible cause of this:

Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8] CD: ComskipJob.executeComskipLinux: comskip failed with return code = 137
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8] java.lang.Exception
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at tmiranda.cd.Log.write(Log.java:64)
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at tmiranda.cd.ComskipJob.executeComskipLinux(ComskipJob.java:386)
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at tmiranda.cd.ComskipJob.executeComskip(ComskipJob.java:173)
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at tmiranda.cd.ComskipJob.executeUsingDefault(ComskipJob.java:187)
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at tmiranda.cd.ComskipJob.run(ComskipJob.java:130)
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at java.lang.Thread.run(Thread.java:745)
Wed 6/14 18:00:15.116 [Thread-506@37ab0fa8] CD: ComskipJob.updateRatio: Old, Current and new Ratios 0.10536681:0.0028583333:0.09511596
Wed 6/14 18:00:16.541 [EPG@17c2c73d] SDEPG Set the system clock to be Wed 6/14 18:00:16.169

this was on SageTV Docker. The hole SageTV server was locked up because I stopped the docker but got no more log entries but the above. If you want more than just the exception out of the log I have 10 files worth of log so even compressed it won't fit. Tell me how far back you want and I will try smaller number(s). I increased the number of log files when I was having a Wiz.bin file size a few months ago and never reduced it. I thought it might just be a problem comskip had and not directly related to Commercial Detector itself. But thought it couldn't hurt to ask.

[Toddly]

Is there any reason that the Commercial Detector plugin will not detect commercials on some of my recorded shows. For some reason it works on the major network shows (NBC,ABC,FOX) yet will not mark shows of the cable channels. Is this an encryption problem or some kind of configuration issue.

I use Xfinity through a HD Homerun and a cable card.
Thanks for any help you can provide.

[NetworkGuy]

Originally Posted by Toddly

Is there any reason that the Commercial Detector plugin will not detect commercials on some of my recorded shows. For some reason it works on the major network shows (NBC,ABC,FOX) yet will not mark shows of the cable channels. Is this an encryption problem or some kind of configuration issue.

I use Xfinity through a HD Homerun and a cable card.
Thanks for any help you can provide.

I also have the same issue. Xfinity with HDHomeRun / cable card.

[Korny]

Networkguy, do you have the donator version of comskip.exe installed, if not that is probably your problem. The free version does not process h264 streams.

[waynedunham]

Originally Posted by Korny

Networkguy, do you have the donator version of comskip.exe installed, if not that is probably your problem. The free version does not process h264 streams.

I don't know if they ever addressed this, and to be honest I don't know how it would verify you have a valid donator license, but in the past if you just installed the plugin and then replaced comskip with the donator version in the "default" directory the next time that the plugin updated it would overwrite your donator version with the standard version.

Create a new directory for the donator version (I used \comskip donator\ as my directory) and place the donator files there. Then go into the settings for Comskip Playback Options (settings\detailed\customize, way down near the bottom) and within that menu on one of the selections are the settings for the commercial detector. Withing that menu you can tell it where "comskip" and its .ini file are. Point those to your donator version directory\ comskip and .ini.
Also buriied within that menu system is the option to put a manual comskip option on the recordings detail for a recording. Make sure that one is set to point to your donator version as well.

[tmiranda]

Originally Posted by BobPhoenix

Thoughts on possible cause of this:

Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8] CD: ComskipJob.executeComskipLinux: comskip failed with return code = 137
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8] java.lang.Exception
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at tmiranda.cd.Log.write(Log.java:64)
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at tmiranda.cd.ComskipJob.executeComskipLinux(ComskipJob.java:386)
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at tmiranda.cd.ComskipJob.executeComskip(ComskipJob.java:173)
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at tmiranda.cd.ComskipJob.executeUsingDefault(ComskipJob.java:187)
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at tmiranda.cd.ComskipJob.run(ComskipJob.java:130)
Wed 6/14 18:00:15.115 [Thread-506@37ab0fa8]     at java.lang.Thread.run(Thread.java:745)
Wed 6/14 18:00:15.116 [Thread-506@37ab0fa8] CD: ComskipJob.updateRatio: Old, Current and new Ratios 0.10536681:0.0028583333:0.09511596
Wed 6/14 18:00:16.541 [EPG@17c2c73d] SDEPG Set the system clock to be Wed 6/14 18:00:16.169

this was on SageTV Docker. The hole SageTV server was locked up because I stopped the docker but got no more log entries but the above. If you want more than just the exception out of the log I have 10 files worth of log so even compressed it won't fit. Tell me how far back you want and I will try smaller number(s). I increased the number of log files when I was having a Wiz.bin file size a few months ago and never reduced it. I thought it might just be a problem comskip had and not directly related to Commercial Detector itself. But thought it couldn't hurt to ask.

Yes, this is what happens when comskip fails. I'd have to look up the comskip error code to see what went wrong. I don't think this is what caused your lock-up.

[NetworkGuy]

Originally Posted by waynedunham

I don't know if they ever addressed this, and to be honest I don't know how it would verify you have a valid donator license, but in the past if you just installed the plugin and then replaced comskip with the donator version in the "default" directory the next time that the plugin updated it would overwrite your donator version with the standard version.

Create a new directory for the donator version (I used \comskip donator\ as my directory) and place the donator files there. Then go into the settings for Comskip Playback Options (settings\detailed\customize, way down near the bottom) and within that menu on one of the selections are the settings for the commercial detector. Withing that menu you can tell it where "comskip" and its .ini file are. Point those to your donator version directory\ comskip and .ini.
Also buriied within that menu system is the option to put a manual comskip option on the recordings detail for a recording. Make sure that one is set to point to your donator version as well.

I am not sure, but I will get a donator version and install it in a separate directory.

Thanks!