Windows Installer

[tmiranda]

Tried updating the YouTube plugin but I am getting an internal error from the plugin submit engine

[tmiranda]

If somebody running the latest STV (version 9.1.7.0 dated Aug 12, 2017) wants a fix, it is attached.

To install it, first install the YouTube (2015) plugin normally then replace the YouTube.stvi file (located in the STVs/SageTV7 folder) with the one in the attached ZIP file. You will need to reload the UI after replacing the .stvi file.

[wnjj]

Jusjoken,

Originally Posted by jusjoken

That would be great. Either approach i can incorporate into the installer build.

k

I was able to get some kind of ImageLoader.dll compiled. I have no idea if it works.

I used Mingw/Msys and started from the buildso.sh script. That script built the intermediate libaries giflib, jpeg-6b, libpng and tiff which are static-linked into ImageLoader.dll.

I did have to modify a couple things along the way (in Makefile.win and Mingw stdint.h). I likely didn't have the right/new enough Mingw. I found Mingw confusing with the abandoned original site and the -64 version which looks up to date, plus there's multiple ways to install stuff.


I had to add

typedef unsigned char u_int8_t;
typedef unsigned short u_int16_t;
typedef unsigned int u_int32_t;

to stdint.h in the Mingw include directory.


The ImageLoader makefile (Makefile.win) needed "-I../../../native/include" added to the CFLAGS in order to find "sage_media_image_ImageLoader.h" when compiling. I also changed the "-W1" to "-W" since the Mingw gcc compilier didn't like W1. Again, maybe a Mingw version issue. Adding "-s" and "-static-libgcc" reduces the size and external dependencies. I then changed the library references in the compiler line since it seems somebody had compiled all of the png/tiff/etc libraries and put them in /mingw/lib. I just hard referenced them into their native place instead. Lastly, change the jdk include paths to your current one.

Here's my resulting Makefile.win:

CC=gcc
CFLAGS = -c -O2 -s -D_JNI_IMPLEMENTATION -I/mingw/include -IC:\\jdk1.4\\include -IC:\\jdk1.4\\include\\win32 -I/usr/local/include -I../../../native/include -DJava_sage_media_image_ImageLoader_createThumbnail=_Java_sage_media_image_ImageLoader_createThumbnail -DJava_sage_media_image_ImageLoader_loadScaledImageFromFile=_Java_sage_media_image_ImageLoader_loadScaledImageFromFile -DJava_sage_media_image_ImageLoader_freeImage0=_Java_sage_media_image_ImageLoader_freeImage0 -DJava_sage_media_image_ImageLoader_compressImageToFile=_Java_sage_media_image_ImageLoader_compressImageToFile -DJava_sage_media_image_ImageLoader_loadImageDimensionsFromFile=_Java_sage_media_image_ImageLoader_loadImageDimensionsFromFile -DJava_sage_media_image_ImageLoader_scaleRawImage=_Java_sage_media_image_ImageLoader_scaleRawImage

OBJFILES=imageload.o sage_media_image_ImageLoader.o

all: swscale.dll ImageLoader.dll

swscale.dll: swscale.o 
	$(CC) -shared -W -o swscale.dll swscale.o -L/mingw/lib -L/usr/local/lib

ImageLoader.dll: $(OBJFILES)
	$(CC) -s -static-libgcc -shared -W -o ImageLoader.dll $(OBJFILES) ../../codecs/giflib/lib/.libs/libgif.a ../../codecs/libpng/.libs/libpng12.a ../../codecs/jpeg-6b/libjpeg.a -lz ../../codecs/tiff/libtiff/.libs/libtiff.a -L. -lswscale

imagetest: test.o $(OBJFILES) 
	$(CC) -s -static-libgcc test.c -o imagetest.exe $(OBJFILES) ../../codecs/giflib/lib/.libs/libgif.a ../../codecs/libpng/.libs/libpng12.a ../../codecs/jpeg-6b/libjpeg.a -lz ../../codecs/tiff/libtiff/.libs/libtiff.a -L. -lswscale

swscale.o: swscale_template.c

clean:
	rm -f *.o imagetest ImageLoader.dll *.c~ *.h~ swscale.dll

swscale.c in the ImageLoader directory didn't match the one compiling for Linux in third_party/swscale and it needed 'static' added to a few inline functions:

  static inline void rgb24to32(
  static inline void rgb32to24(
  static inline void rgb24tobgr24(
  static inline void rgb32tobgr32(

One other snag I ran into when compiling giflib/utils: gifclrmp.c wouldn't compile as it's referencing header files from the library itself. Not sure why but we don't need the utils anyway so I just moved on. It should get fixed to be proper but I commented out the error check in the main script for now.


Here's the final script I used. I called it 'builddll.sh' like the corresponding 'buildso.sh' for Linux, placed in the 'buildwin' directory and ran it from there.

#!/bin/sh

mkdir dll
cd dll

# build the image library dependencies
cd ../../third_party/codecs/giflib
./configure --with-pic || { echo "Build failed, exiting."; exit 1; }
make  # Building utils has an issue.  Skip error check.  || { echo "Build failed, exiting."; exit 1; }

cd ../jpeg-6b
./configure CFLAGS=-fPIC || { echo "Build failed, exiting."; exit 1; }
make

cd ../libpng
./configure --with-pic || { echo "Build failed, exiting."; exit 1; }
make

cd ../tiff
./configure --with-pic || { echo "Build failed, exiting."; exit 1; }
make

cd ../../../buildwin/dll

make -C ../../third_party/SageTV-LGPL/imageload -f Makefile.win || { echo "Build failed, exiting."; exit 1; }
cp ../../third_party/SageTV-LGPL/imageload/*.dll .

It makes swscale.dll and ImageLoader.dll in the 'buildwin/dll' directory.

I think that's all. I don't have any more time to spend on this for now or a github account for that matter but if you want to try with these instructions, feel free.

[jusjoken]

Thanks to wnjj for the help with compiling the imageloader dll so the fix that affected EPG images (and others) is now resolved in windows too (was resolved in linux a while ago).

9.1.7 has a STV changes thanks to OPUS4...look at the change log here...

k

[jusjoken]

Originally Posted by graywolf

Great Job, guess I missed that.

This is how the installer now indicates where it will be installing...



Hopefully that will help... not sure when I will have time to get it to FIND the previous install.

k

[SHS]

Originally Posted by jusjoken

This is how the installer now indicates where it will be installing...


Hopefully that will help... not sure when I will have time to get it to FIND the previous install.

k

Thanks
That cool there not that lazy they could uninstall it and re-install it

[rickgillyon]

Originally Posted by jusjoken

Thanks to wnjj for the help with compiling the imageloader dll so the fix that affected EPG images (and others) is now resolved in windows too (was resolved in linux a while ago).

On the Client, thumbnails aren't being created. If I've looked at a show in the EPG on the server, the thumbnail is there; if I look at it on the PC Client, the thumbnail is never generated. This is just since 9.1.7. See attachment.

[jusjoken]

Originally Posted by rickgillyon

On the Client, thumbnails aren't being created. If I've looked at a show in the EPG on the server, the thumbnail is there; if I look at it on the PC Client, the thumbnail is never generated. This is just since 9.1.7. See attachment.

Any errors in the client's log?

I will install a client and try it out...not sure why it would be different

k

[rickgillyon]

Originally Posted by jusjoken

Any errors in the client's log?

None that I can see, log attached. You can see where it tries to generate the thumbnail in the previous attachment ("Match of the Day"), but none appears in the client.

[jusjoken]

Odd... I just setup a client and I get the images without issue in the guide on the client.

I am assuming you meant windows client.

What server are you connecting to? OS and version ?

k

[rickgillyon]

Win10 everywhere, up-to-date. This wasn't guide it was recordings.

[jusjoken]

Are you seeing the images elsewhere...like the guide ?

I just tried the recordings and also do not get an image but then I installed 9.1.6 and also do not get an image so not sure I validated anything.

Not sure I will have more time this morning to look for an issue so hopefully others will chime in with their experiences so we can narrow this down.

k

[rickgillyon]

To be clear, I see images in Recording so long as the thumbnail has been generated elsewhere (e.g. on the server) first.

There are errors in the server log 20 seconds after this which may be relevant:

Mon 9/25 10:10:31.154 [ConnRecvQueue@6f3b2e] Error communicating with server:java.io.EOFException
Mon 9/25 10:10:31.154 [ConnRecvQueue@6f3b2e] Cleaning up c/s connection
Mon 9/25 10:10:31.155 [ConnRecvQueue@6f3b2e] NetworkManager CommunicationFailure : /192.168.1.4:50713 type=1
Mon 9/25 10:10:31.155 [ConnRecvQueue@6f3b2e] NetworkClient fullCleanup /192.168.1.4:50713
Mon 9/25 10:10:31.156 [ConnRecvQueue@6f3b2e] Cleaning up c/s connection
Mon 9/25 10:10:31.156 [ConnRecvQueue@6f3b2e] Cleaning up c/s connection

192.168.1.4 is where the client was running.

[SHS]

Originally Posted by rickgillyon

To be clear, I see images in Recording so long as the thumbnail has been generated elsewhere (e.g. on the server) first.

Try clear out your thumbnail folder on both server and client in
?:\Program Files (x86)\SageTV\SageTV\GeneratedThumbnails\
Or where ever you may have it install

[rickgillyon]

Originally Posted by SHS

Try clear out your thumbnail folder on both server and client in
?:\Program Files (x86)\SageTV\SageTV\GeneratedThumbnails\
Or where ever you may have it install

Thumbnails for Videos are regenerated after clearing, for recordings not so. Looks like it's creating zero-length images in GeneratedThumbnails.

[SHS]

Originally Posted by rickgillyon

Thumbnails for Videos are regenerated after clearing, for recordings not so. Looks like it's creating zero-length images in GeneratedThumbnails.

That odd I see them for the recordings

[rickgillyon]

Originally Posted by SHS

That odd I see them for the recordings

TS files?

[SHS]

Originally Posted by rickgillyon

TS files?

Both ts and mpeg see screenshot with ts

[jusjoken]

Originally Posted by rickgillyon

Thumbnails for Videos are regenerated after clearing, for recordings not so. Looks like it's creating zero-length images in GeneratedThumbnails.

Do you have any fanart plugin installed?

k

[SHS]

Originally Posted by jusjoken

Do you have any fanart plugin installed?

k

I don't I only have stock run mill SageTV install