Plugin: CommercialDetector

[Taddeusz]

Running this on my experimental Linux server with the latest version of comskip. Was working with v0.81.076 just fine. Now with v0.81.088 I get an error after logo detection with the message, "Application tried to create a window, but no driver could be loaded".

Runs fine if I run from gui command line. Crashes if run from ssh, etc. I don't see any Window appear when run from within X though.

[tmiranda]

Originally Posted by Taddeusz

Running this on my experimental Linux server with the latest version of comskip. Was working with v0.81.076 just fine. Now with v0.81.088 I get an error after logo detection with the message, "Application tried to create a window, but no driver could be loaded".

Runs fine if I run from gui command line. Crashes if run from ssh, etc. I don't see any Window appear when run from within X though.

Are you using wine? What command line are you using?

[Taddeusz]

Originally Posted by tmiranda

Are you using wine? What command line are you using?

Yes, wine. Not sure what you mean. My ini file didn't change. Just passing the video file to comskip.

[tmiranda]

Originally Posted by Taddeusz

Yes, wine. Not sure what you mean. My ini file didn't change. Just passing the video file to comskip.

I was confused by your statement "Runs fine if I run from gui command line. Crashes if run from ssh, etc."

I also don't know what you mean by "I get an error after logo detection with the message..."

[Taddeusz]

Originally Posted by tmiranda

I was confused by your statement "Runs fine if I run from gui command line. Crashes if run from ssh, etc."

I also don't know what you mean by "I get an error after logo detection with the message..."

Sorry, what I mean is that it's crashing. Doing some testing it runs fine without any errors when the current directory is the one where comskip.exe resides. When run from outside the comskip directory (e.g. from /media/recordings/tv) it crashes with an exception once it hits the end of logo processing.

[Taddeusz]

Also, what I've been inferring is that comskip is crashing during live detection at the end of logo processing.

[Taddeusz]

Ok, this is weirder than I thought. It only crashes if there's not already a logo.txt file. If that file already exists it runs just fine.

[tmiranda]

Originally Posted by Taddeusz

Ok, this is weirder than I thought. It only crashes if there's not already a logo.txt file. If that file already exists it runs just fine.

If comskip is crashing I think you should seek support there first. I'd just be grasping at straws. Probably not the answer you wanted to hear ...

In the meantime you can revert back to the older version of comskip.

[scoful]

I can't get the donator version of comskip to work with commercial detector. Commercial detector launches it, and it produces EDL's but there's nothing of significance in the EDL. If I manually run ComSkip it does produce cuts, so it's pretty baffling. If I downgrade to the version included in ComskipMonitor (which I used to use) it seems to work fine - except of course it's slower and won't multi-thread. Also - does Commercial Detector only run on an active SageTV/SageTVClient? My server is headless and normally I don't login to it, but it doesn't appear to process anything unless Sage is open on it.

[Taddeusz]

Originally Posted by scoful

I can't get the donator version of comskip to work with commercial detector. Commercial detector launches it, and it produces EDL's but there's nothing of significance in the EDL. If I manually run ComSkip it does produce cuts, so it's pretty baffling. If I downgrade to the version included in ComskipMonitor (which I used to use) it seems to work fine - except of course it's slower and won't multi-thread. Also - does Commercial Detector only run on an active SageTV/SageTVClient? My server is headless and normally I don't login to it, but it doesn't appear to process anything unless Sage is open on it.

Do you have live_tv=1 in the comskip.ini?

[tmiranda]

Originally Posted by scoful

I can't get the donator version of comskip to work with commercial detector. Commercial detector launches it, and it produces EDL's but there's nothing of significance in the EDL. If I manually run ComSkip it does produce cuts, so it's pretty baffling. If I downgrade to the version included in ComskipMonitor (which I used to use) it seems to work fine - except of course it's slower and won't multi-thread. Also - does Commercial Detector only run on an active SageTV/SageTVClient? My server is headless and normally I don't login to it, but it doesn't appear to process anything unless Sage is open on it.

It could be that CommercialDetector is using an .ini file that the new version of comskip doesn't like. Take a look at the logs to see what .ini file is being used. Or you can just change the settings to use a "known good" .ini. The .ini used by CommercialDetector is slightly tweaked from the stock .ini that ships with comskip.

CommercialDetector only runs on a SageTV server. It captures "recording completed" events and then runs comskip against the completed recording. Does that answer your second question?

[scoful]

Originally Posted by tmiranda

CommercialDetector only runs on a SageTV server. It captures "recording completed" events and then runs comskip against the completed recording. Does that answer your second question?

So I don't need to be logged in, correct?

[Fuzzy]

Originally Posted by scoful

So I don't need to be logged in, correct?

Not if the service is running.

[tmiranda]

Originally Posted by Fuzzy

Not if the service is running.

Correct.

[scoful]

Originally Posted by tmiranda

Correct.

Perfect! Thanks.

[tmiranda]

A new version of CommercialDetector, CommercialDetector UI, and comskip are available. There is no functionality change from previous versions, I just moved the hosting to BinTray.

[KryptoNyte]

Tom, I noticed the updates the other day, so I went ahead and let it run. After the updates, comskip stopped skipping on h.264 files. Is it possible that comskip.exe was replaced during the update with a non-donator version?

[tmiranda]

Originally Posted by KryptoNyte

Tom, I noticed the updates the other day, so I went ahead and let it run. After the updates, comskip stopped skipping on h.264 files. Is it possible that comskip.exe was replaced during the update with a non-donator version?

Yes. The plugin uses a free version of comskip. You need to go into the setup and point it at your donator version. (There is a way to tell COmmercialDetector where to look for the comskip.exe and comskip,ini files.)

[KryptoNyte]

Understood. I've always just found and copied the donator comskip.exe over the one in the Commercial Detector (CD) install directory. I've seen the two different file paths in the CD Sage UI settings screen, but it honestly never dawned on me to use that as [I now understand] it was intended. Thank you.

[Fuzzy]

Originally Posted by KryptoNyte

Understood. I've always just found and copied the donator comskip.exe over the one in the Commercial Detector (CD) install directory. I've seen the two different file paths in the CD Sage UI settings screen, but it honestly never dawned on me to use that as [I now understand] it was intended. Thank you.

Yeah, the main problem with replacing the .exe's with the donator version, is the plugin system will later just overwrite them with the free version on the next update (as you've found).