STV Import: Comskip Playback w/ support for EDL

[Stuntman]

Verified that if I 'fix' the spaces in the comskip .edl file to 'tabs' then the .stvi file will now see the commercial breaks! Will have to bring that to Erik's attention.. I see several of my .edl files that have spaces in some places and tabs in others... and/or.. could you look for space/tab as a deliminator?

[sundansx]

I take that back, it did the split on anything except numbers 0-9. I had to change this to anything but 0-9 and a period..like:
commercials = java_lang_String_split(bytes,"[^0-9\\.]+")

anyone have any input on this regular expression?

[sundansx]

Ah, I see the problem...I am doing a replace of "\t0" to nuke that last column of 0's. This looks for tab 0. not entirely robust, but seemed to satisfy the file format I was looking at. Im thinking a better way would be to do a "0[\r\n]" to make it more robust...

[sundansx]

OK,
try this one and let me know how it works...it still works on mine and now looks for a carridge return or a line feed at the last column to eliminate the last zero. Anyone know what the is that column for, anyway?

I will beta test this version for a while and release it if it is doing good...

[erik]

The .edl format is specified by mencoder/mplayer
The last zero is to signal that the indicated segment has to be skipped.
If the last zero would be a 1 than that segment should be muted.

[erik]

Originally Posted by Stuntman

Verified that if I 'fix' the spaces in the comskip .edl file to 'tabs' then the .stvi file will now see the commercial breaks! Will have to bring that to Erik's attention.. I see several of my .edl files that have spaces in some places and tabs in others... and/or.. could you look for space/tab as a deliminator?

COmskip always generates spaces in the .edl file, never tabs (at least, its not in the code)
I can change it easily to tabs, but mencoder/mplayer can handle both tabs and spaces.

[hemicuda]

Originally Posted by sundansx

OK,
try this one and let me know how it works...it still works on mine and now looks for a carridge return or a line feed at the last column to eliminate the last zero. Anyone know what the is that column for, anyway?

I will beta test this version for a while and release it if it is doing good...

WOOT! working for me except for that same loop issue someone else had at 00:00. great plug-in/apps people

[Stuntman]

Originally Posted by sundansx

OK,
try this one and let me know how it works...it still works on mine and now looks for a carridge return or a line feed at the last column to eliminate the last zero. Anyone know what the is that column for, anyway?

I will beta test this version for a while and release it if it is doing good...

Looks good at first glance.. will test further... Erik says he will use tabs in his next version, though it now appears you may have worked around the issue.. though it never hurts to standardize

I'll report again if I see any problems..

[Stuntman]

Originally Posted by hemicuda

WOOT! working for me except for that same loop issue someone else had at 00:00. great plug-in/apps people

I still see that looping issue too... I'll keep using the .txt version of my data until that bugger gets fixed.. Comskip is great in that it will produce both .txt and .edl for me..

[erik]

Could you download and test comskip 0.79 build 49?

It can be found at
http://mk.kaashoek.com/comskip/files/comskip79_49.zip

[erik]

When using the new build look at the readme.txt for what has changed.
Do keep your old ini file.

F.y.i.

Changes in 0.79.49
- Bug solved: SageTV needs tabs instead of spaces in the .edl file
- Bug solved: SaveTV gets into a loop when a very short commercial at the start is detected.
Changes in 0.79.48
- Bug solved: remove_after does not have any effect, all commercials shortened with fps frames.
Changes in 0.79.47
- Bug solved: Certain DVR-MS files cause a buffer overrun in sound decoding
- Parameter added: BTV requires a longer time to check for end of recording during live_tv. Set live_tv_retries=8 in the ini file.
Changes in 0.79.46
- Added two ini file parameters, remove_before and remove_after, will remove the given amount of seconds of show before or after ALL commercials
- Increase amount of memory available during live_tv processing to prevent out_of_memory crash when processing very long recordings.
Changes in 0.79.45
- Bug solved: A TS file with MANY PID's causes Comskip to crash
- Improved algorithm to deal with LiveTV in BTV 4.3
Changes in 0.79.44
- Added in the debugwindow the option to toggle blocks between commercial and show. Is available after processing an mpeg or a .csv file. Output files are rewritten after each toggle. The refference bar stays at the original detection results. Use the 'T' key to toggle

[erik]

The top change should be build 49

[sundansx]

OK, I looked quick and think I found the cause of the bug that keeps comskip disabled after you do a manual skip. I think it happens if you do two manual skips in a row before the timeout. I am now thinking of a better way to do this and will update for the next stvi release.
For me, I had problems with this in the old stvi also, strangely some people reported that they did not encounter this problem back then. This is an area that I didnt make any changes in the new one. It is probably a corner usage case that I use a lot and others do not...

[blade]

Originally Posted by sundansx

OK, I looked quick and think I found the cause of the bug that keeps comskip disabled after you do a manual skip. I think it happens if you do two manual skips in a row before the timeout. I am now thinking of a better way to do this and will update for the next stvi release.
For me, I had problems with this in the old stvi also, strangely some people reported that they did not encounter this problem back then. This is an area that I didnt make any changes in the new one. It is probably a corner usage case that I use a lot and others do not...

I've always had problems with it in the old .stvi as well.

[Stuntman]

I've noticed that since adding this .stvi tht when a video ends the recordings menu doesn't come up any more.. the video just freezes at where it ended and waits for me to 'close' it manually..

Anybody else seeing this?

[Stuntman]

Originally Posted by erik

- Bug solved: SaveTV gets into a loop when a very short commercial at the start is detected.

I'm still seeing this bug... was trying to watch a ghost hunters episode and it got stuck at the 5 second mark.. there was a short commercial in front of the show start... it repeats over and over.. but not always the same.. some of the loops get a fraction of a second further.. like it is trying to get past it...

This is what the contents of that .edl file show..

0.03 5.87 0
613.78 835.63 0
1383.38 1563.93 0
1928.73 2078.84 0
2398.33 2600.36 0
2957.82 3149.25 0
3599.33 3599.36 0

Thanks!

[erik]

Mmm. will set the boundaries some wider, next build,

[erik]

Done, could you download build 50 and test?

[Stuntman]

Originally Posted by erik

Done, could you download build 50 and test?

Sure thing.. doing so now..

I seem to recall seeing this occur also at the end of one of my recordings, have you adjusted for that as well? I'll watch carefully over the next few nights and report anything I find.

[Stuntman]

Originally Posted by Stuntman

Sure thing.. doing so now..

I seem to recall seeing this occur also at the end of one of my recordings, have you adjusted for that as well? I'll watch carefully over the next few nights and report anything I find.

Ran new version against the 'Ghost Hunters' episode that was previously causing the looping.. and it still looks, same place as far as I can tell.

If you like I could provide the .mpg file and the .edl file to you for study..

-Robert